Repository navigation
Conversation
jolt-lang/time v0.0.9 has an unescaped quote in a docstring that jolt 0.8.25 rejects, which broke every task under jolt, build included. Pin the commit that fixes it. The tests read JSON with cheshire, which only bb bundles, so they use clojure.data.json now, and the one call to a private fn goes through its var, as Clojure requires.
jolt does bundle clojure.test. The real reason serve is bb-only is http-kit. The site.serve.jolt twin the comments described never existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said test and serve need bb because jolt doesn't bundle clojure.test. It does. What actually stopped the tests was cheshire (bb-only), a direct call to a private fn, and jolt-lang/time v0.0.9, whose locale-data docstring has an unescaped quote that jolt 0.8.25 rejects. That last one also broke jolt run build.
The time pin moves to the commit with the fix (no tag has it yet), the tests use clojure.data.json, and the README and info text now say only serve is bb-only (http-kit). jolt test and bb test both pass, 110 tests; jolt run build works again. Also drops the comments describing a site.serve.jolt twin that was never committed.